[Pacemaker] System Health backend patch part 1

[Mark Hamzy]

andrew at beekhof.net wrote on 06/09/2009 00:00:20 AM:

> You might find:
>
> +   syslog (LOG_INFO, "Event id:        "U64T"\n", event_id);
> +   syslog (LOG_INFO, "Log timestamp:   %s\n", ctime (&(event->
time_logged)));
> +   syslog (LOG_INFO, "Event timestamp: %s\n", ctime (&(event->
time_event)));
>
> to be quite noisy.  Perhaps LOG_DEBUG and/or combining them into a
> single line would be a good idea.
>
> +       if (execvp (attrd_updater_args[0], attrd_updater_args) == -1)
>
> I think instead of exec'ing attrd_updater, you might as well link
> against libcrmcommon.so and use the attrd_update_no_mainloop()  API
> call.

Here is a new version of the patch with those issues addressed:

(See attached file: pacemaker.mark.patch)

Mark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20090609/ac803de3/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pacemaker.mark.patch
Type: application/octet-stream
Size: 12765 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20090609/ac803de3/attachment-0001.obj>