[Pacemaker] Why are fatal warnings enabled by default?

[Steven Dake]

IMO enabling fatal warnings by default when having a bunch of dependent
header files, then enabling most warnings in the warn list is
problematic.

Header files are consistently broken upstream wrt const correctness,
typing, etc.  With fatal warnings enabled its really difficult to get a
clean compile on many platforms because the header files are broken.

Just look as nss libs in rhel5/centos.  Header files broken with certain
warnings.

But do what you like :)

Regards
-steve

On Wed, 2009-10-21 at 15:08 +0200, Florian Haas wrote:
> On 2009-10-21 14:36, Dejan Muhamedagic wrote:
> >>> The warnings being?
> >> In agents, a simple "./configure && make" leads to:
> >>
> >> [...]
> >> gmake[1]: Entering directory `/home/rpmbuild/hg/cluster-agents/heartbeat'
> >> if gcc -DHAVE_CONFIG_H -I. -I. -I../include -I../include -I../include
> >> -I../linux-ha  -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include    -g
> >> -O2 -ggdb3 -O0  -fgnu89-inline -fstack-protector-all -Wall
> >> -Waggregate-return -Wbad-function-cast -Wcast-qual -Wcast-align
> >> -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal -Wformat=2
> >> -Wformat-security -Wformat-nonliteral -Winline -Wmissing-prototypes
> >> -Wmissing-declarations -Wmissing-format-attribute -Wnested-externs
> >> -Wno-long-long -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes
> >> -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror -MT IPv6addr.o
> >> -MD -MP -MF ".deps/IPv6addr.Tpo" -c -o IPv6addr.o IPv6addr.c; \
> >> 	then mv -f ".deps/IPv6addr.Tpo" ".deps/IPv6addr.Po"; else rm -f
> >> ".deps/IPv6addr.Tpo"; exit 1; fi
> >> cc1: warnings being treated as errors
> >> IPv6addr.c: In function ‘send_ua’:
> >> IPv6addr.c:453: warning: passing argument 2 of
> >> ‘libnet_pblock_record_ip_offset’ makes pointer from integer without a cast
> > 
> > This doesn't happen here with libnet-1.1.2.1-140.75.i586. Which
> > libnet version do you have?
> 
> libnet-1.1.4-3.el5
> 
> Cheers,
> Florian
> 
> _______________________________________________
> Pacemaker mailing list
> Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker