[ClusterLabs] [Announce] libqb 10.rc3 release

Christine Caulfield ccaulfie at redhat.com
Tue Mar 1 08:32:11 UTC 2016


On 26/02/16 07:58, Jan Pokorný wrote:
> On 26/02/16 14:27 +0900, Keisuke MORI wrote:
>> As of libqb-1.0rc3, Pacemaker fails to build upon it with the gcc
>> warnings as below.
>> There was no such a problem until 1.0rc2, and it seems that the
>> changes in the pull request #175 is related.
>>
>> https://github.com/ClusterLabs/libqb/pull/175
>>
>> {{{
>> [root at build-centos71 pacemaker ((Pacemaker-1.1.14))]# rpm -qa | grep libqb
>> libqb-1.0rc3-1.el7.x86_64
>> libqb-devel-1.0rc3-1.el7.x86_64
>>
>> [root at build-centos71 pacemaker ((Pacemaker-1.1.14))]# git checkout
>> Pacemaker-1.1.14
>> HEAD is now at 70404b0... Merge pull request #892 from kgaillot/1.1
>> [root at build-centos71 pacemaker ((Pacemaker-1.1.14))]# make release
>> (snip)
>> In file included from ../../include/crm_internal.h:33:0,
>>                  from ipc.c:19:
>> ipc.c: In function 'crm_ipcs_flush_events':
>> ../../include/crm/common/logging.h:140:23: error: format '%d' expects
>> argument of type 'int', but argument 10 has type 'ssize_t'
>> [-Werror=format=]
>>          static struct qb_log_callsite *trace_cs = NULL;                 \
>>                        ^
>> ../../include/crm/common/logging.h:254:37: note: in expansion of macro
>> 'do_crm_log_unlikely'
>>  #  define crm_trace(fmt, args...)   do_crm_log_unlikely(LOG_TRACE,
>> fmt , ##args)
>>                                      ^
>> [...]
> 
> Looks like that PR of mine turned out to be generally a good thing as it
> effectively discovers wrong printf-format usage compared to the actual
> arguments, exactly according to what you report :-)
> 
> Will take care of the problematic code in Pacemaker.
> 
> 

Good work :-)

Chrissie





More information about the Users mailing list