[ClusterLabs] Antw: OCF agent validation proposal (was Re: fence_scsi no such device)

Ulrich Windl Ulrich.Windl at rz.uni-regensburg.de
Tue Mar 22 10:52:56 CET 2016


>>> Kristoffer Grönlund <kgronlund at suse.com> schrieb am 22.03.2016 um 09:40 in
Nachricht <87lh5ahpmr.fsf at krigpad.kri.gs>:
> Jan Pokorný <jpokorny at redhat.com> writes:
> 
>> Hmm, I keep lamenting that by extending agents metadata with inline
>> RelaxNG grammar to express co-occurrence/mutual exclusion of
>> particular parameters and/or its datatype in detail, and by using
>> that information at the configuration front-ends, we would push
>> the overall user experience to the new level
>> (https://bugzilla.redhat.com/show_bug.cgi?id=1281463#c4).
> 
> Incidentally, my plan for today was to create a submit request for
> resource-agents adding a validation regex for resource parameters, just
> to see if I could get a discussion going. I'd really like to see
> something like this as well.

Could you explain why checking parameters with the validate method is
sufficient. Saying that validate doesn't check the parameters for validity is
probably not an argument.
Otherwise I think most parameters have a syntax too complex to check before
passing it to validate, considering that the default types are unspecific as
"(string|integer|boolean|time)".
For example, there is no syntax for a non-negative integer, for a positive
integer, for a fractional value, for an IPv4 address, for a file name, etc.

Regards,
Ulrich




More information about the Users mailing list