[ClusterLabs] Two bugs in fence_ec2 script

[Kristoffer Grönlund]

Marek marx Grác <mgrac at redhat.com> writes:

> Hi,
>
> fence_ec2 is not part of official upstream (https://github.com/ClusterLabs/fence-agents/) yet. There are various issues that blocks it, see archive if you are interested. 
>
> Anyway thanks for patch and I hope people will find it there.
>
> m,
>

A fork of fence_ec2 has been merged in cluster-glue as
stonith:external/ec2. It has already received additional patches
since being merged there:

http://hg.linux-ha.org/glue/file/56f40ec5d37e/lib/plugins/stonith/external/ec2

Error #1 as described below has already been fixed in the gluster-glue
version. The second issue (#2) is not a problem for glue stonith agents.

Cheers,
Kristoffer

>
>
>
>
> On 5 February 2016 at 16:11:02, Steve Marshall (steve.marshall at weather.com) wrote:
>> I've found two bugs in the fence_ec2 script found in this RPM:
>> fence_ec2-0.1-0.10.1.x86_64.rpm
>>  
>> I believe this is the latest and greatest, but I may be wrong. I'm not
>> sure where to post these fixes, so I'm starting here. If there is a better
>> place to post, please let me know.
>>  
>> The errors are:
>> 1. The tag attribute does not default to "Name", as specified in the
>> documentation
>> 2. The script does not accept attribute settings from stdin
>>  
>> #1 is not critical, since tag=Name can be specified explicitly when setting
>> up a stonith resource. However, #2 is very important, since stonith_admin
>> (and I think most of pacemaker) passes arguments to fencing scripts via
>> stdin. Without this fix, fence_ec2 will not work properly via pacemaker,
>> that is:
>>  
>> This command works....
>> fence_ec2 --action=metadata
>>  
>> ...but this alternate version of same command does not:
>> echo "action=metadata" | fence_ec2
>>  
>> The fixes are relatively trivial. The version of fence_ec2 from the RPM is
>> attached as fence_ec2.old. My modified version is attached as
>> fence_ec2.new. I've also attached the RPM that was the source for
>> fence_ec2.old.
>> _______________________________________________
>> Users mailing list: Users at clusterlabs.org
>> http://clusterlabs.org/mailman/listinfo/users
>>  
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>> Bugs: http://bugs.clusterlabs.org
>>  
>
>
> _______________________________________________
> Users mailing list: Users at clusterlabs.org
> http://clusterlabs.org/mailman/listinfo/users
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org

-- 
// Kristoffer Grönlund
// kgronlund at suse.com