[ClusterLabs] Antw: Re: [Question] Question about mysql RA.

[renayama19661014 at ybb.ne.jp]

Hi Ken,
Hi Ulrich,

Hi All,

I sent a patch.
 * https://github.com/ClusterLabs/resource-agents/pull/698

Please confirm it.

Best Regards,
Hideo Yamauchi.


----- Original Message -----
> From: "renayama19661014 at ybb.ne.jp" <renayama19661014 at ybb.ne.jp>
> To: Cluster Labs - All topics related to open-source clustering welcomed <users at clusterlabs.org>
> Cc: 
> Date: 2015/11/5, Thu 19:36
> Subject: Re: [ClusterLabs] Antw: Re:  [Question] Question about mysql RA.
> 
> Hi Ken,
> Hi Ulrich,
> 
> Thank you for comment
> 
> The RA of mysql seemed to have a problem somehow or other from the beginning as 
> far as I heard the opinion of Ken and Ulrich.
> 
> I wait for the opinion of other people a little more, and I make a patch.
> 
> Best Regards,
> Hideo Yamauchi.
> 
> 
> ----- Original Message -----
>>  From: Ulrich Windl <Ulrich.Windl at rz.uni-regensburg.de>
>>  To: users at clusterlabs.org; kgaillot at redhat.com
>>  Cc: 
>>  Date: 2015/11/5, Thu 16:11
>>  Subject: [ClusterLabs] Antw: Re:  [Question] Question about mysql RA.
>> 
>>>>>   Ken Gaillot <kgaillot at redhat.com> schrieb am 04.11.2015 
> um 
>>  16:44 in Nachricht
>>  <563A27C2.5090003 at redhat.com>:
>>>   On 11/04/2015 04:36 AM, renayama19661014 at ybb.ne.jp wrote:
>>  [...]
>>>>       pid=`cat $OCF_RESKEY_pid 2> /dev/null `
>>>>       /bin/kill $pid > /dev/null
>>> 
>>>   I think before this line, the RA should do a "kill -0" to 
> check 
>>  whether
>>>   the PID is running, and return $OCF_SUCCESS if not. That way, we can
>>>   still return an error if the real kill fails.
>> 
>>  And remove the stale PID file if there is no such pid. For very busy 
> systems one 
>>  could use ps for that PID to see whether the PID belongs to the expected 
>>  process. There is a small chance that a PID exists, but does not belong to 
> the 
>>  expected process...
>> 
>>> 
>>>>       rc=$?
>>>>       if [ $rc != 0 ]; then
>>>>           ocf_exit_reason "MySQL couldn't be stopped"
>>>>           return $OCF_ERR_GENERIC
>>>>       fi
>>>>   (snip)
>>>>   ---------------------------------------------------------
>>>> 
>>>>   The mysql RA does such a code from old days.
>>>>    * http://hg.linux-ha.org/agents/file/67234f982ab7/heartbeat/mysql 
> 
>>>> 
>>>>   Does mysql RA know the reason becoming this made?
>>>>   Possibly is it a factor to be conscious of mysql cluster?
>>>> 
>>>>   I think about a patch of this movement of mysql RA.
>>>>   I want to know the detailed reason.
>>>> 
>>>>   Best Regards,
>>>>   Hideo Yamauchi.
>>> 
>>> 
>>>   _______________________________________________
>>>   Users mailing list: Users at clusterlabs.org 
>>>   http://clusterlabs.org/mailman/listinfo/users 
>>> 
>>>   Project Home: http://www.clusterlabs.org 
>>>   Getting started: 
> http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf 
>>>   Bugs: http://bugs.clusterlabs.org 
>> 
>> 
>> 
>> 
>> 
>>  _______________________________________________
>>  Users mailing list: Users at clusterlabs.org
>>  http://clusterlabs.org/mailman/listinfo/users
>> 
>>  Project Home: http://www.clusterlabs.org
>>  Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>>  Bugs: http://bugs.clusterlabs.org
>> 
> 
> _______________________________________________
> Users mailing list: Users at clusterlabs.org
> http://clusterlabs.org/mailman/listinfo/users
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org
>