[Pacemaker] Are you correct about the calculation of quorum when booth renews a ticket?

[Yuichi SEINO]

Hi Jiaju,

2013/1/14 Jiaju Zhang <jjzhang at suse.de>:
> Hi Yuichi,
>
> Thanks for the patch!
>
> However, I need to say some coding style problem first;) I didn't say
> this before, so it seems a little bit messy and will confuse a lot of
> contributors and users, sorry for the inconvenience;)
>
> Now I'd like to say that booth is inclined to use the Linux kernel
> coding style. For the existing problems in the booth repository, I'm
> going to cleanup the code soon. For the newly submitted patches, I'd
> like them to obey the kernel coding style.
>
> So Yuichi, before I looked at this patch in more detail, could you use
> the checkpatch.pl (in kernel source tree) script to check the patch
> first?;)

OK.
I pushed a commit after I used checkpatch.pl. in Linux 3.7.2

Sincerely,
Yuichi

>
> Thank you very much!
>
> Regards,
> Jiaju
>
> On Sat, 2013-01-12 at 00:48 +0900, Yuichi SEINO wrote:
>> Hi Jiaju,
>>
>> I could fix this issue.I send the pull request.
>> https://github.com/jjzhang/booth/pull/47
>>
>> Sincerely,
>> Yuichi
>>
>> 2012/12/25 Jiaju Zhang <jjzhang at suse.de>:
>> > Hi Yuichi,
>> >
>> > Thanks for the reporting! It should be a bug that learned_max has not
>> > been reset after a successful learning process.
>> >
>> > Thanks,
>> > Jiaju
>> >
>> > On Tue, 2012-12-25 at 11:28 +0900, Yuichi SEINO wrote:
>> >> Hi Jiaju,
>> >>
>> >> Even if booth lacks a quorum, booth may write a ticket in cib when
>> >> booth renews a ticket. Are you correct about this work?
>> >>
>> >> I try inserting the following debug code.
>> >>
>> >> diff --git a/src/paxos.c b/src/paxos.c
>> >> index c0ab5b9..53eadb5 100644
>> >> --- a/src/paxos.c
>> >> +++ b/src/paxos.c
>> >> @@ -145,6 +145,7 @@ static int have_quorum(struct paxos_space *ps, int member)
>> >>                         sum++;
>> >>         }
>> >>
>> >> +       log_debug("total %d, current %d", sum, member);
>> >>         if (member * 2 > sum)
>> >>                 return 1;
>> >>         else
>> >>
>> >> And, I got the following debug log when booth renews a ticket. And, I
>> >> made 5 sites.
>> >> ...
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: learner response ...
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: total 5, current 78
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: enter lease_learned
>> >> ...
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: learner response ...
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: total 5, current 79
>> >> booth-site[26305]: 2012/12/25_02:08:40 debug: enter lease_learned
>> >>
>> >> I think that the number of  vote is cumulative sum when booth renews a ticket.
>> >>
>> >> Sincerely,
>> >> Yuichi
>> >>


--
Yuichi SEINO
METROSYSTEMS CORPORATION
E-mail:seino.cluster2 at gmail.com