[Pacemaker] Suggestion to improve movement of booth

[yusuke iida]

Hi, Jiaju

It understood leaving processing of is_prepared().
I did "pull request" of judgment processing.
Please confirm it.

https://github.com/jjzhang/booth/pull/50

Regards,
Yusuke

2013/2/18 Jiaju Zhang <jjzhang at suse.de>:
> On Thu, 2013-02-14 at 11:36 +0900, yusuke iida wrote:
>> Hi, Jiaju
>>
>> Thank you for reply!
>>
>> 2013/2/12 Jiaju Zhang <jjzhang at suse.de>:
>> > Hi Yusuke,
>> >
>> > On Tue, 2013-02-12 at 13:08 +0900, yusuke iida wrote:
>> >> Hi, Jiaju
>> >>
>> >> Could you please reply to this message?
>> >
>> > My suggestion is no need to add additional configuration options, in
>> > this case, the behavior of booth is definitive, return a negative value
>> > in lease_promise.
>>
>> I understood it.
>> According to your suggestion, I cancel the additional setting option.
>> I change the judgment of current lease_promise to the form according
>> to "master lease".
>>
>> When this logic is taken in, "hdr->leased = 1" thinks that processing
>> of lease_is_prepare becomes unnecessary since it will not be
>> transmitted.
>
> Yes, actually it would be necessary.
>
>> Is this processing still required?
>
> The processing of judging hdr->leased in is_prepared function is not
> required any more, but I'd like to keep the is_prepared callback there,
> in case we need it in the future.
>
> Thanks,
> Jiaju
>
>



-- 
----------------------------------------
METRO SYSTEMS CO., LTD

Yusuke Iida
Mail: yusk.iida at gmail.com
----------------------------------------

2013/2/18 Jiaju Zhang <jjzhang at suse.de>:
> On Thu, 2013-02-14 at 11:36 +0900, yusuke iida wrote:
>> Hi, Jiaju
>>
>> Thank you for reply!
>>
>> 2013/2/12 Jiaju Zhang <jjzhang at suse.de>:
>> > Hi Yusuke,
>> >
>> > On Tue, 2013-02-12 at 13:08 +0900, yusuke iida wrote:
>> >> Hi, Jiaju
>> >>
>> >> Could you please reply to this message?
>> >
>> > My suggestion is no need to add additional configuration options, in
>> > this case, the behavior of booth is definitive, return a negative value
>> > in lease_promise.
>>
>> I understood it.
>> According to your suggestion, I cancel the additional setting option.
>> I change the judgment of current lease_promise to the form according
>> to "master lease".
>>
>> When this logic is taken in, "hdr->leased = 1" thinks that processing
>> of lease_is_prepare becomes unnecessary since it will not be
>> transmitted.
>
> Yes, actually it would be necessary.
>
>> Is this processing still required?
>
> The processing of judging hdr->leased in is_prepared function is not
> required any more, but I'd like to keep the is_prepared callback there,
> in case we need it in the future.
>
> Thanks,
> Jiaju
>
>



--
----------------------------------------
METRO SYSTEMS CO., LTD

Yusuke Iida
Mail: yusk.iida at gmail.com
----------------------------------------