[Pacemaker] booth is the state of "started" on pacemaker before booth write ticket info in cib.

[Yuichi SEINO]

Hi Xia,

I watched your patch. Probably, I think that this patch has a problem
with the following check. Do you need if "rv" is equal to 0? The lseek
man describes that the lseek return -1 if the lseek error happens.
Otherwise, lseek return the number of bytes. So, 0 may not be error.
And, this patch includes several "rv <= 0". What do you think about
it?


+ rv = lseek(fd, 0, SEEK_SET);
+ if (rv <= 0) {
+ log_error("lseek set offset to 0 error: %d: %s",
+ fd, strerror(errno));
+ }

Sincerely,
Yuichi


2013/2/1 Yuichi SEINO <seino.cluster2 at gmail.com>:
> Hi Xia,
>
> Thanks for the patch. I have a question.
>
> Following errors always be output. Are you correct about the log level?
> If this isn't a error, it would be better to output as a log info.
> And, I attached the log.
>
> ERROR: lseek set offset to 0 error: 4: Success
> or
> ERROR: lseek set offset to 0 error: 4: Operation now in progress
>
> Sincerely,
> Yuichi
>


--
Yuichi SEINO
METROSYSTEMS CORPORATION
E-mail:seino.cluster2 at gmail.com