[Pacemaker] dc-version and cluster-infrastructure cluster options may be lost when editing

[Vladislav Bogdanov]

Hi all,

Just discovered that it is possible to remove options in subject with
admin action (at least with cibadmin --patch).

This is notably annoying when updating CIB with 'crm configure load
update' (which uses crm_diff to create patch) when updating other
cluster options.

While most (all?) other options are reset to defaults when they are
missing in the input, those two in subject are silently removed. That
is probably a bug. IMO such "internal" options should be preserved
(filtered?) from external updates.

I noticed this while debugging problem with one of my resource-agents
which polls for cluster-infrastructure attribute during start - it
refused to restart after cluster options update.

Would be nice to have this fixed in 1.1.11 :)

Relevant log lines are:
Dec 20 10:54:21 booter-test-0 cib[3517]:   notice: cib:diff: --         <nvpair id="cib-bootstrap-options-dc-version" name="dc-version" value="1.1.10-3.3.el6-8db9f0b"/>
Dec 20 10:54:21 booter-test-0 cib[3517]:   notice: cib:diff: --         <nvpair id="cib-bootstrap-options-cluster-infrastructure" name="cluster-infrastructure" value="corosync"/>

Versions are:
pacemaker - ClusterLabs/pacemaker/master 0d1ac18 + beekhof/pacemaker/master a269ba8
crmsh - 4f66cc190185


Best,
Vladislav