[Pacemaker] crm shell and corosync2 node id

[Dejan Muhamedagic]

On Thu, Sep 13, 2012 at 04:15:10PM +0300, Vladislav Bogdanov wrote:
> 13.09.2012 15:37, Dejan Muhamedagic wrote:
> > Hi,
> > 
> > On Thu, Sep 13, 2012 at 02:57:54PM +0300, Vladislav Bogdanov wrote:
> >> Hi Dejan, all,
> >>
> >> current crm shell (b58a3398bf11) can not parse node 'id' attribute when
> >> running on corosync 2:
> >>
> >> # crm configure show |grep xml
> >> INFO: object 1074005258 cannot be represented in the CLI notation
> >> INFO: object 1090782474 cannot be represented in the CLI notation
> >> INFO: object 1107559690 cannot be represented in the CLI notation
> >> INFO: object 1124336906 cannot be represented in the CLI notation
> >> xml <node id="1074005258" uname="vd01-a"> \
> >> xml <node id="1090782474" uname="vd01-b"> \
> >> xml <node id="1107559690" uname="vd01-c"> \
> >> xml <node id="1124336906" uname="vd01-d"> \
> > 
> > A quick test here shows that it can:
> > 
> > $ crm configure show 1074005258
> > node $id="1074005258" lmb-virt-01 \
> > 	attributes cores="2" \
> > 	utilization cores="2"
> > $ crm configure show xml 1074005258
> > ...
> > 	<node id="1074005258" type="normal" uname="lmb-virt-01">
> > 
> > Hmm, I wonder if the type attribute missing is a problem here.
> 
> Yes. I added it and crm does not complain anymore. But now I cannot
> remove it with crm configure edit xml ;)

Well, it shouldn't bother you either, right? :) The thing is
that there's no type in the default CLI representation, so, the
attribute being required (as it was), the shell always supplies
one.

> > IIRC, it used to be a required attribute and it is so here in
> > v1.1.7. Looks like that changed in the meantime.
> 
> May be. I run current master and node objects were created by pacemaker.

Having it optional will make things more complicated in a subtle
way, as there's now no single way to present simple "node node1"
(i.e. it could have type="normal", but then it doesn't have to).

> I'll test your patch tomorrow.

Thanks!

Dejan

> Thank you,
> Vladislav
> 
> > 
> > Thanks,
> > 
> > Dejan
> > 
> >>
> >> Best,
> >> Vladislav
> >>
> >> _______________________________________________
> >> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> >> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> >>
> >> Project Home: http://www.clusterlabs.org
> >> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> >> Bugs: http://bugs.clusterlabs.org
> > 
> > _______________________________________________
> > Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> > http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> > 
> > Project Home: http://www.clusterlabs.org
> > Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> > Bugs: http://bugs.clusterlabs.org
> > 
> 
> 
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://bugs.clusterlabs.org