[Pacemaker] OCF exit code 8 triggers WARN message

[Dejan Muhamedagic]

Hi Thilo,

On Fri, Sep 16, 2011 at 04:41:59PM +0200, Thilo Uttendorfer wrote:
> Hi,
> 
> I experience a lot of "WARN" log entries in several pacemaker cluster setups:
> 
> Sep 16 11:53:21 server01 lrmd: [23946]: WARN: Managed res1:0:monitor process 
> 26489 exited with return code 8.
> 
> That's because multi state resources like DRBD have some special return 
> codes. "8" means OCF_RUNNING_MASTER which should not trigger a warning. The 
> folowing patch in cluster-clue solved this issue:
> 
> -------------
> diff -u  lib/clplumbing/proctrack.c lib/clplumbing/proctrack.c.patched
> 
> --- lib/clplumbing/proctrack.c  2011-09-16 15:48:25.000000000 +0200
> +++ lib/clplumbing/proctrack.c.patched  2011-09-16 15:51:43.000000000 +0200
> @@ -271,7 +271,7 @@
>  
>         if (doreport) {
>                 if (deathbyexit) {
> -                       cl_log((exitcode == 0 ? LOG_INFO : LOG_WARNING)
> +                       cl_log(((exitcode == 0 || exitcode == 8) ? LOG_INFO : 
> LOG_WARNING)
>                         ,       "Managed %s process %d exited with return 
> code %d."
>                         ,       type, pid, exitcode);
>                 }else if (deathbysig) {
> -------------

I did consider this before but was worried that a process
different from OCF RA instance could exit with such a code. Code
7 (not running) also belongs to this category. Anyway, we should
probably add this patch.

Many thanks for the patch.

Dejan

> 
> Thilo
> 
> 
> 
> -- 
> Thilo Uttendorfer
> Linux Information Systems AG
> Putzbrunner Str. 71, 81739 München
> 
> Fon: +49 89 993412-11, Fax: +49 89 993412-99
> t.uttendorfer at linux-ag.com, http://www.linux-ag.com
> 
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker