[Pacemaker] Patch for bugzilla 2541: Shell should warn if parameter uniqueness is violated

Holger Teutsch holger.teutsch at web.de
Thu Mar 3 04:43:37 EST 2011


Hi,
I submit a patch for
"bugzilla 2541: Shell should warn if parameter uniqueness is violated"
for discussion.

devel1:~ # crm configure
crm(live)configure# primitive ip1a ocf:heartbeat:IPaddr2 params ip="1.2.3.4" meta target-role="stopped"
crm(live)configure# primitive ip1b ocf:heartbeat:IPaddr2 params ip="1.2.3.4" meta target-role="stopped"
crm(live)configure# primitive ip2a ocf:heartbeat:IPaddr2 params ip="1.2.3.5" meta target-role="stopped"
crm(live)configure# primitive ip2b ocf:heartbeat:IPaddr2 params ip="1.2.3.5" meta target-role="stopped"
crm(live)configure# primitive ip3 ocf:heartbeat:IPaddr2 params ip="1.2.3.6" meta target-role="stopped"
crm(live)configure# primitive dummy_1 ocf:heartbeat:Dummy params fake="abc" meta target-role="stopped"
crm(live)configure# primitive dummy_2 ocf:heartbeat:Dummy params fake="abc" meta target-role="stopped"
crm(live)configure# primitive dummy_3 ocf:heartbeat:Dummy meta target-role="stopped"
crm(live)configure# commit
WARNING: Violations of instance parameters with attribute unique detected:
  Agent "ocf:heartbeat:IPaddr2" parameter "ip" value "1.2.3.4" in resources
          ip1a
          ip1b

  Agent "ocf:heartbeat:IPaddr2" parameter "ip" value "1.2.3.5" in resources
          ip2a
          ip2b

Do you still want to commit? n
crm(live)configure#

The code now lives in ui.py. I'm not sure whether it should be considered as more cib related an be moved to some other module.

Regards
Holger

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shell.diff
Type: text/x-patch
Size: 2980 bytes
Desc: not available
URL: <http://lists.clusterlabs.org/pipermail/pacemaker/attachments/20110303/01b22d4d/attachment-0002.bin>


More information about the Pacemaker mailing list