[Pacemaker] About updated attribute value output in the DC node

[Yoshihiko SATO]

Hi Andrew,

Thanks for your quick reply.

I remade the patch by the means to add to existing logic.
(attachment : update_log1.patch)

If it is possible, i want to get also the attribute names of XML("name", "value") for log analysis.
So, update_log2.patch is better for me.
I would like to hear your any opinion.

Regards,
Yoshihiko SATO

(2011/07/05 12:09), Andrew Beekhof wrote:
> On Tue, Jul 5, 2011 at 12:36 PM, Yoshihiko SATO
> <satoyoshi at intellilink.co.jp>  wrote:
>> Hi Andrew,
>>
>> Thank you for advice.
>>
>>>
>>> In this case I'd just append " $name=$value"
>>>
>> Sorry, I don't understand..
>> Your meaning is checking the attribute name and value that are null or not?
>
> I mean to the log message.
> If its TYPE(reason) == nvpair, then add " %s=%s" to the string to
> display the name and value.
>
> 		do_crm_log(log_level,
> 			   "%s:%d - Triggered transition abort (complete=%d, tag=%s, id=%s,
> magic=%s) : %s",
> 			   fn, line, transition_graph->complete, TYPE(reason), ID(reason),
> magic?magic:"NA", abort_text);
>
>
> Makes sense?
>
> (Weird being in the same timezone :-)
>
>>
>>
>> Regards,
>> Yoshihiko SATO
>>
>> (2011/07/05 10:39), Andrew Beekhof wrote:
>>>
>>> On Mon, Jul 4, 2011 at 8:05 PM, Yoshihiko SATO
>>> <satoyoshi at intellilink.co.jp>    wrote:
>>>>
>>>> Hi Andrew,
>>>>
>>>> Thanks for your comment.
>>>>
>>>> Do you mean that the output logic is branched by some conditions?
>>>
>>> Right
>>>
>>>> If my understanding is correct, What conditions should we judge?
>>>> "tag"(TYPE(reason)), "abort_text" or otherwise?
>>>>
>>>>   - TYPE(reason) == "nvpair"
>>>>        Is it all right judging as attribute update?
>>>
>>> Correct
>>>
>>>>   - abort_text == "Transient attribute: update"
>>>>        I am concerned about changing contents of strings.
>>>
>>> In this case I'd just append " $name=$value"
>>>
>>> _______________________________________________
>>> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
>>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>>
>>> Project Home: http://www.clusterlabs.org
>>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>>> Bugs:
>>> http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>>>
>>
>>
>> _______________________________________________
>> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>> Bugs:
>> http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: update_log1.patch
Type: text/x-patch
Size: 1395 bytes
Desc: not available
URL: <http://oss.clusterlabs.org/pipermail/pacemaker/attachments/20110705/49a2f149/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: update_log2.patch
Type: text/x-patch
Size: 1860 bytes
Desc: not available
URL: <http://oss.clusterlabs.org/pipermail/pacemaker/attachments/20110705/49a2f149/attachment-0003.bin>