[Pacemaker] [PATCH]Bug 2567 - crm resource migrate should support an optional "role" parameter

[Andrew Beekhof]

On Sun, Apr 24, 2011 at 4:31 PM, Holger Teutsch <holger.teutsch at web.de> wrote:
> On Mon, 2011-04-11 at 20:50 +0200, Andrew Beekhof wrote:
>> why?
>>         CMD_ERR("Resource %s not moved:"
>>                 " specifying --master is not supported for
>> --move-from\n", rsc_id);
>>
> it did not look sensible to me but I can't recall the exact reasons 8-)
> It's now implemented.
>> also the legacy handling is a little off - do a make install and run
>> tools/regression.sh and you'll see what i mean.
>
> Remaining diffs seem to be not related to my changes.

Unlikely I'm afraid.  We run the regression tests after every commit
and complain loudly if they fail.
What is the regression test output?

>
>> other than that the crm_resource part looks pretty good.
>> can you add some regression testcases in tools/ too please?
>>
> Will add them once the code is in the repo.
>
> Latest diffs are attached.
>
> -holger
>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker
>
>