[Pacemaker] [PATCH]Bug 2567 - crm resource migrate should support an optional "role" parameter

Holger Teutsch holger.teutsch at web.de
Sun Apr 24 14:31:33 UTC 2011


On Mon, 2011-04-11 at 20:50 +0200, Andrew Beekhof wrote:
> why?
>         CMD_ERR("Resource %s not moved:"
>                 " specifying --master is not supported for
> --move-from\n", rsc_id);
> 
it did not look sensible to me but I can't recall the exact reasons 8-)
It's now implemented.
> also the legacy handling is a little off - do a make install and run
> tools/regression.sh and you'll see what i mean.

Remaining diffs seem to be not related to my changes.

> other than that the crm_resource part looks pretty good.
> can you add some regression testcases in tools/ too please?
> 
Will add them once the code is in the repo.

Latest diffs are attached.

-holger

-------------- next part --------------
A non-text attachment was scrubbed...
Name: shell_move.diff
Type: text/x-patch
Size: 4923 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20110424/53d43672/attachment-0012.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crm_resource.diff
Type: text/x-patch
Size: 14944 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20110424/53d43672/attachment-0013.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crm_cli.diff
Type: text/x-patch
Size: 2214 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20110424/53d43672/attachment-0014.bin>


More information about the Pacemaker mailing list