[Pacemaker] Patch for pgsql RA

[Florian Haas]

Hi Serge,

On 05/17/2010 07:50 PM, Serge Dubrouski wrote:
> I'm really sorry but please disregard that patch. The more appropriate
> would be these two attached patches.

>  # Validate most critical parameters
>  pgsql_validate_all() {
> -    if ! have_binary $SH
> +    if ! check_binary $SH
>      then
>          return $OCF_ERR_INSTALLED
>      fi

You can just do check_binary. No need for have_binary and any if test;
check_binary just exits with $OCF_ERR_INSTALLED if it doesn't find the
binary.

Wrt the $FUSER patch, is it really necessary to specify the full path to
fuser? Other RAs simply do check_binary <binary>, relying on <binary> to
be found in the $PATH.

Cheers,
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20100517/c97a06e1/attachment-0004.sig>