[Pacemaker] [PATCH] crm_mon expansion patch

[Yuusuke IIDA]

Hi Andrew,

 > Its in the tree as:
 >     http://hg.clusterlabs.org/pacemaker/1.1/rev/b4439579f466
 > and will be in the 1.1.2 release which will be out in the next week or so.
Thank you for an answer.
I'm sorry. Because I confirmed 1.0 all the time, I did not notice.

I let a message output function of pingd support pingRA.
Please merge the patch.

Best Regards,
IIDA Yuusuke

(2010/05/06 15:49), Andrew Beekhof wrote:
> On Thu, May 6, 2010 at 6:10 AM, Yuusuke IIDA<iidayuus at intellilink.co.jp>  wrote:
>> Hi Andrew,
>>
>> Though it passes for a while, when is this patch merged into a source tree
>> by the last reply?
>
> Its in the tree as:
>     http://hg.clusterlabs.org/pacemaker/1.1/rev/b4439579f466
> and will be in the 1.1.2 release which will be out in the next week or so.
>
> As a new feature it can't be considered for 1.0.
>
>>
>> I want to use the function of this patch as an official function early.
>>
>> Best Regards,
>> IIDA Yuusuke
>>
>> (2010/03/24 16:58), Andrew Beekhof wrote:
>>>
>>> On Wed, Mar 24, 2010 at 3:32 AM, Yuusuke IIDA
>>> <iidayuus at intellilink.co.jp>    wrote:
>>>>
>>>> Hi Andrew,
>>>>
>>>> Please confirm it last time because I revised loop processing pointed
>>>> out.
>>>
>>> I like it :-)
>>>
>>> Although I'll probably change it slightly to differentiate between
>>> partial and total failure:
>>>
>>> +               if(crm_parse_int(attrvalue, "0")<= 0) {
>>> +                   print_as("\t: Link has failed (Expected=%d)",
>>> expected_score);
>>> +               } else if(crm_parse_int(attrvalue, "0")<    expected_score)
>>> {
>>> +                   print_as("\t: Link is degraded (Expected=%d)",
>>> expected_score);
>>> +               }
>>>
>>> instead of:
>>>
>>> +               if(crm_parse_int(attrvalue, "0")<    expected_score) {
>>> +                   print_as("\t: Link is failure!! (Expected=%d)",
>>> expected_score);
>>> +               }
>>>
>>> Thanks very much for the patch!
>>>>
>>>> I do not understand the point that this processing does not have good
>>>> well.
>>>>>>>
>>>>>>> Not sure about this bit:
>>>>>>>
>>>>>>> +    if(failcount>        0) {
>>>>>>> +       printed = TRUE;
>>>>>>> +       print_as(": Resource is failure!!");
>>>>>>> +    }
>>>>>>> +
>>>>
>>>> Does this message say that you had better display it when you reached
>>>> migration-threshold?
>>>>
>>>> I revised it incidentally because I discovered that variable "fail_attr"
>>>> made memory leak by the handling of "-f" option.
>>>
>>> Ah, good to have that fixed.
>>>
>>>> I want you to merge even the handling of to display attribute information
>>>> node into a branch of stable-1.0 if I do not have any problem.
>>>
>>> Its not really a bug, so I'll probably just add it to 1.1/devel
>>>
>>> _______________________________________________
>>> Pacemaker mailing list
>>> Pacemaker at oss.clusterlabs.org
>>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>>
>>
>> --
>> ----------------------------------------
>> METRO SYSTEMS CO., LTD
>>
>> YuusukeIida
>> Mail: iidayuus at intellilink.co.jp
>> ----------------------------------------
>>
>> _______________________________________________
>> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
>> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>>
>> Project Home: http://www.clusterlabs.org
>> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>>
>
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
>

-- 
----------------------------------------
METRO SYSTEMS CO., LTD

YuusukeIida
Mail: iidayuus at intellilink.co.jp
----------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crm_mon.c.patch
Type: text/x-patch
Size: 538 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/pacemaker/attachments/20100507/2c0ad589/attachment-0003.bin>