[Pacemaker] Proposing patch for ld --as-needed

[Simon Horman]

On Sat, Jul 17, 2010 at 01:12:20PM +0200, Ultrabug wrote:
> Dear list,
> 
> I would like to ask you about a possible upstream modification regarding the --
> as-needed ld flag for which we Gentoo users need to patch the pacemaker sources 
> to get it compile.
> 
> I'm attaching the patch which, as you can see, is relatively small and simple 
> (looks to me at least). The question is whether or not you think this could be 
> done upstream ?
> 
> Thank you for your interest in this and all you work,

Out of interest, could you explain why this is needed?
Is it because gold is being used as the linker?

> --- pengine/Makefile.am
> +++ pengine/Makefile.am
> @@ -58,6 +58,7 @@
>  # -L$(top_builddir)/lib/pils -lpils -export-dynamic -module -avoid-version
>  libpengine_la_SOURCES	= pengine.c allocate.c utils.c constraints.c \
>  			native.c group.c clone.c master.c graph.c
> +libpengine_la_LIBADD    = $(top_builddir)/lib/pengine/libpe_status.la
> 
>  pengine_SOURCES	= main.c
>  pengine_LDADD	= $(COMMONLIBS)	$(top_builddir)/lib/cib/libcib.la
> --- lib/pengine/Makefile.am
> +++ lib/pengine/Makefile.am
> @@ -34,7 +34,7 @@
> 
>  libpe_status_la_LDFLAGS	= -version-info 2:0:0
>  libpe_status_la_SOURCES	=  $(rule_files) $(status_files)
> -libpe_status_la_LIBADD	= -llrm
> +libpe_status_la_LIBADD	= -llrm @CURSESLIBS@
> 
>  clean-generic:
>  	rm -f *.log *.debug *~

> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker