[Pacemaker] [PATCH] suggested bashism fixes for hb2openais.sh

[Dejan Muhamedagic]

Hi,

On Wed, Jul 07, 2010 at 01:12:20AM +0200, Lars Ellenberg wrote:
> On Tue, Jul 06, 2010 at 04:45:13PM +0200, Raoul Bhatia [IPAX] wrote:
> > # HG changeset patch
> > # User Raoul Bhatia [IPAX] <r.bhatia at ipax.at>
> > # Date 1278427473 -7200
> > # Branch stable-1.0
> > # Node ID 6396b06964a167a53b57b80ab316c96c9de3ab39
> > # Parent  31401399d6334467296a60a13d0cea7641fc9358
> > suggested bashism fixes for hb2openais.sh
> > 
> > diff -r 31401399d633 -r 6396b06964a1 tools/hb2openais.sh.in
> > --- a/tools/hb2openais.sh.in	Tue Jul 06 16:29:38 2010 +0200
> > +++ b/tools/hb2openais.sh.in	Tue Jul 06 16:44:33 2010 +0200
> > @@ -384,10 +384,10 @@
> >  newstanza() {
> >  	do_tabs
> >  	printf "%s {\n" $1
> > -	let sw=sw+1
> > +	sw=$((sw+1))
> 
> all of these need to be sw=$(( $sw + 1 ))
> and similar.
> 
> ok, so it also works like this in "recent" dash.
> but it won't work with older dash, or ash, or ...
> so if you start on shell compatibility, go all the way ;-)
> 
> why not simply require bash?
> 
> Dejan?

Yes, this is just an auxiliary script, I'll make it a bash
script.

Cheers,

Dejan

> -- 
> : Lars Ellenberg
> : LINBIT | Your Way to High Availability
> : DRBD/HA support and consulting http://www.linbit.com
> 
> DRBD® and LINBIT® are registered trademarks of LINBIT, Austria.
> 
> _______________________________________________
> Pacemaker mailing list: Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> 
> Project Home: http://www.clusterlabs.org
> Getting started: http://www.clusterlabs.org/doc/Cluster_from_Scratch.pdf
> Bugs: http://developerbugs.linux-foundation.org/enter_bug.cgi?product=Pacemaker