[Pacemaker] 1.0.9 forgets to pass arguments to the agent

[Bernd Schubert]

How can it happen that parameters are missing in 1.0.9?

The following condition is *sometimes* triggered (in our lustre_server agent, 
which is is a modified Filesystem agent)

# It is possible that OCF_RESKEY_directory has one or even multiple trailing "/".
# But the output of `mount` and /proc/mounts do not.
if [ -z "$OCF_RESKEY_directory" ]; then
        ocf_log err "Please specify the directory! OP=\"$OP\" DEVICE=\"$DEVICE\""
        exit $OCF_ERR_ARGS 
else
        MOUNTPOINT=$(echo $OCF_RESKEY_directory | sed 's/\/*$//')
        : ${MOUNTPOINT:=/}
        # At this stage, $MOUNTPOINT does not contain trailing "/" unless it is "/"
        # TODO: / mounted via lustre_server sounds dangerous. On stop, we'll
        # kill the whole system. Is that a good idea?
fi


Jul 12 00:10:14 phys-oss1 crmd: [25804]: info: do_lrm_rsc_op: Performing key=44:15:0:086740fe-9fc3-42dc-bf40-ae737b4ad405 op=ost_demofs_0_sto
p_0 )
Jul 12 00:10:14 phys-oss1 lrmd: [25801]: info: rsc:ost_demofs_0:122: stop
Jul 12 00:10:14 phys-oss1 cib: [12157]: info: retrieveCib: Reading cluster configuration from: /var/lib/heartbeat/crm/cib.dL8UaU (digest: /va
r/lib/heartbeat/crm/cib.LzvqUx)
Jul 12 00:10:15 phys-oss1 lustre_server[12158]: [12163]: ERROR: Please specify the directory! OP="stop" DEVICE=""
Jul 12 00:10:15 phys-oss1 crmd: [25804]: info: process_lrm_event: LRM operation ost_demofs_0_stop_0 (call=122, rc=2, cib-update=215, 
confirmed=true) invalid parameter
Jul 12 00:10:16 phys-oss1 attrd: [25803]: info: attrd_ha_callback: Update relayed from phys-mds0
Jul 12 00:10:16 phys-oss1 attrd: [25803]: info: attrd_trigger_update: Sending flush op to all hosts for: fail-count-ost_demofs_0 (INFINITY)
Jul 12 00:10:16 phys-oss1 attrd: [25803]: info: attrd_perform_update: Sent update 958: fail-count-ost_demofs_0=INFINITY
Jul 12 00:10:16 phys-oss1 attrd: [25803]: info: attrd_ha_callback: Update relayed from phys-mds0
Jul 12 00:10:16 phys-oss1 attrd: [25803]: info: attrd_trigger_update: Sending flush op to all hosts for: last-failure-ost_demofs_0 
(1278886216)


I guess I need to fill a bugzilla, but I won't have time before Wednesday.


Thanks,
Bernd