[Pacemaker] build problem: HA_LIBDIR/HA_HBCONF_DIR redefined

[Dejan Muhamedagic]

Hi,

On Sun, Oct 11, 2009 at 09:33:24PM +0200, Andrew Beekhof wrote:
> On Thu, Oct 8, 2009 at 5:10 PM, Johan Verrept <Johan.Verrept at able.be> wrote:
> > On Tue, 2009-10-06 at 17:15 +0200, Andrew Beekhof wrote:
> >> Anyway, I committed some changes to glue and hb3 which should fix the problem.
> >
> > Apparantly, it didn't quite work. I upgraded to the current tips of
> > clusterglue, resource-agents and heartbeat. Pacemaker is still 1.0.5
> >
> > pacemaker:   In file included from /ub/include/heartbeat/heartbeat.h:38,
> > pacemaker:                    from stonithd.c:92:
> > pacemaker:   /ub/include/heartbeat/hb_config.h:37:1: error: "HA_LIBDIR"
> > redefined
> > pacemaker:   In file included from /ub/include/pils/plugin.h:24,
> > pacemaker:                    from stonithd.c:77:
> > pacemaker:   /ub/include/heartbeat/glue_config.h:25:1: error: this is
> > the location of the previous definition
> >
> > hb_config contains:
> >
> >        /* Custom name for libdir */
> >        #define HA_LIBDIR "/ub/lib"
> >
> >        #include <heartbeat/glue_config.h>
> >
> > glue_config contains:
> >
> >        /* Location for daemons */
> >        #define HA_LIBHBDIR "/ub/lib/heartbeat"
> >
> >        #define HA_LIBDIR "/ub/lib/heartbeat"
> 
> Then you didn't update glue properly :-)
> glue_config.h doesn't contain HA_LIBDIR anymore.
> 
> >
> > So still different for HA_LIBDIR. I do not provide them in my builds, so
> > I guess they are (wrongly) autodetected?
> >
> > FYI, something else has broken since...
> > It builds fine with disable-fatal-warnings.
> >
> > clusterglue:   make[3]: Entering directory
> > `/root/work/Reusable-Cluster-Components-f0f15f5d8339/lib/plugins/lrm'
> > clusterglue:   if /bin/sh ../../../libtool --tag=CC  --tag=CC
> > --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I. -I../../../include
> > -I../../../include -I../../../include -I../../../include
> > -I../../../linux-ha -I../../../linux-ha -I../../../libltdl
> > -I../../../libltdl  -I/ub/include/glib-2.0 -I/ub/lib/glib-2.0/include
> > -I/ub/include/libxml2  -g -O2 -ggdb3 -O0  -fgnu89-inline
> > -fstack-protector-all -Wall -Waggregate-return -Wbad-function-cast
> > -Wcast-qual -Wcast-align -Wdeclaration-after-statement -Wendif-labels
> > -Wfloat-equal -Wformat=2 -Wformat-security -Wformat-nonliteral -Winline
> > -Wmissing-prototypes -Wmissing-declarations -Wmissing-format-attribute
> > -Wnested-externs -Wno-long-long -Wno-strict-aliasing -Wpointer-arith
> > -Wstrict-prototypes -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY
> > -Werror -MT raexeclsb.lo -MD -MP -MF ".deps/raexeclsb.Tpo" -c -o
> > raexeclsb.lo raexeclsb.c; \
> > clusterglue:    then mv -f ".deps/raexeclsb.Tpo" ".deps/raexeclsb.Plo";
> > else rm -f ".deps/raexeclsb.Tpo"; exit 1; fi
> > clusterglue:   libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.
> > -I../../../include -I../../../include -I../../../include
> > -I../../../include -I../../../linux-ha -I../../../linux-ha
> > -I../../../libltdl -I../../../libltdl -I/ub/include/glib-2.0
> > -I/ub/lib/glib-2.0/include -I/ub/include/libxml2 -g -O2 -ggdb3 -O0
> > -fgnu89-inline -fstack-protector-all -Wall -Waggregate-return
> > -Wbad-function-cast -Wcast-qual -Wcast-align
> > -Wdeclaration-after-statement -Wendif-labels -Wfloat-equal -Wformat=2
> > -Wformat-security -Wformat-nonliteral -Winline -Wmissing-prototypes
> > -Wmissing-declarations -Wmissing-format-attribute -Wnested-externs
> > -Wno-long-long -Wno-strict-aliasing -Wpointer-arith -Wstrict-prototypes
> > -Wwrite-strings -ansi -D_GNU_SOURCE -DANSI_ONLY -Werror -MT raexeclsb.lo
> > -MD -MP -MF .deps/raexeclsb.Tpo -c raexeclsb.c  -fPIC -DPIC
> > -o .libs/raexeclsb.o
> > clusterglue:   cc1: warnings being treated as errors
> > clusterglue:   raexeclsb.c: In function 'execra':
> > clusterglue:   raexeclsb.c:211: warning: unused variable 'exit_value'
> > clusterglue:   make[3]: *** [raexeclsb.lo] Error 1
> > clusterglue:   make[3]: Leaving directory
> > `/root/work/Reusable-Cluster-Components-f0f15f5d8339/lib/plugins/lrm'

This one's mine. Fixed today.

Thanks,

Dejan