[Pacemaker] cib still leaks in pacemaker-1.0.3

[Andrew Beekhof]

Ah, well that was pretty obvious.
/me humbly apologizes for such a stupid error.

(It wasn't caught by my own valgrind testing because this function is
specific to heartbeat based clusters)


Try this:

diff -r ea5d0b58c0be cib/callbacks.c
--- a/cib/callbacks.c	Wed May 20 11:56:39 2009 +0200
+++ b/cib/callbacks.c	Wed May 20 14:01:30 2009 +0200
@@ -1064,6 +1064,7 @@ cib_ha_peer_callback(HA_Message * msg, v
 {
     xmlNode *xml = convert_ha_message(NULL, msg, __FUNCTION__);
     cib_peer_callback(xml, private_data);
+    free_xml(xml);
 }

 void




On Tue, May 19, 2009 at 8:24 PM, Andrew Beekhof <andrew at beekhof.net> wrote:
> I'll take a look at the valgrind data.  Thanks!
>
> On Tue, May 19, 2009 at 6:39 PM, Nikola Ciprich <extmaillist at linuxbox.cz> wrote:
>> Hello,
>> sorry to bother again. I've discovered why valgrind didn't
>> find anything. It is important to stop the process in order to
>> have valgrind finish the analysis. And it seems that there
>> really are leaks not only in cib, but also in attrd and crmd.
>> I just had a slight look into the code reported by valgrind
>> as problematic and though I would certainly need to examine
>> it much more to understand it properly, I think there are
>> leaks. I'm attaching the valgrind reports, In case You would be
>> interested in examining them.
>> If I could provide any help, I'll be more than happy.
>> (well, I guess I could of course help by sending patches :) but I'm
>> afraid this will take me a lot of time, I can try though).
>> with best regards
>> nik
>>
>>> Not really. Sorry :(
>>>
>>
>> --
>> -------------------------------------
>> Nikola CIPRICH
>> LinuxBox.cz, s.r.o.
>> 28. rijna 168, 709 01 Ostrava
>>
>> tel.:   +420 596 603 142
>> fax:    +420 596 621 273
>> mobil:  +420 777 093 799
>>
>> www.linuxbox.cz
>>
>> mobil servis: +420 737 238 656
>> email servis: servis at linuxbox.cz
>> -------------------------------------
>>
>