[Pacemaker] [PATCH]The abolition of distinguishing a node name by a small and capital letter.

[renayama19661014 at ybb.ne.jp]

Hi all,

Thank you for understanding of all of you.

> Yes, though that means changing all plugins.
I can assist the revision of the plug in.


Best Regards,
Hideo Yamauchi.

--- Dejan Muhamedagic <dejanmm at fastmail.fm> wrote:

> Hi Lars,
> 
> On Tue, Dec 15, 2009 at 02:24:42PM +0100, Lars Ellenberg wrote:
> > On Tue, Dec 15, 2009 at 11:25:41AM +0100, Dejan Muhamedagic wrote:
> > > Hi Hideo-san,
> > > 
> > > On Tue, Dec 15, 2009 at 09:22:35AM +0900, renayama19661014 at ybb.ne.jp wrote:
> > > > Hi Dejan,
> > > > 
> > > > > Are node names uppercase? And then stonith doesn't work?
> > > > 
> > > > The node name is a small letter. 
> > > 
> > > Well, why would they put in uppercase names then?
> > > 
> > > > stonith acts, but it is not carried out because it is not found an target node.
> > > > 
> > > > It is caused by a mistake of the setting obviously. 
> > > > However, for a user, some kind of measures are necessary.
> > > 
> > > Sorry, this smells like wontfix :)
> > 
> > Hm. let me try to summarize my understanding of this thread.
> > 
> > Hostnames are in general case insensitive.
> > 
> > In pacemaker/openais/heartbeat, in most places, this is correctly taken
> > care of by using strcasecmp(3) or tolower(3) in C code where
> > appropriate.
> 
> Correctly :) We have a bugzilla open for this, because it
> breaks configurations with node names which contain uppercase
> letters. But I doubt that that will be fixed. Basically, the only
> way is to just have lowercase host names.
> 
> > some stonith plugins however seem to be case sensitive,
> > and will just break when one uses hostnames with inappropriate case.
> > 
> > Hideo-san proposes to fix that stonith plugin,
> > to make it deal with hostnames case insensitive as well
> > (as the rest of the cluster stack and dns and whatever does),
> > but to warn about the fact that there is some case mismatch between
> > spelling in some config file and "hostlist detection" of the stonith plugin.
> 
> My understanding was that the user placed uppercase node names in
> the stonith configuration, but the node names are actually
> lowercase. But if your understanding is correct, then we may fix
> this.
> 
> > Hideo-san,
> > if my understanding of your proposal is correct,
> > then I think that should just be done.
> > makes the code more robust,
> > follows principle of least surprise etc.
> > 
> > there may even be plugins that can only "autodetect" in all caps
> > because of limitations in the firmware of the hardware used.
> > I don't know.
> 
> Right, could be, but that should be dealt with in the plugin.
> 
> > but either folding hostnames to all lowercase,
> > or using strcasecmp, sounds reasonable.
> 
> Yes, though that means changing all plugins.
> 
> Cheers,
> 
> Dejan
> 
> 
> > Thanks,
> > 
> > -- 
> > : Lars Ellenberg
> > : LINBIT | Your Way to High Availability
> > : DRBD/HA support and consulting http://www.linbit.com
> > 
> > DRBD召・and LINBIT召・are registered trademarks of LINBIT, Austria.
> > 
> > _______________________________________________
> > Pacemaker mailing list
> > Pacemaker at oss.clusterlabs.org
> > http://oss.clusterlabs.org/mailman/listinfo/pacemaker
> 
> _______________________________________________
> Pacemaker mailing list
> Pacemaker at oss.clusterlabs.org
> http://oss.clusterlabs.org/mailman/listinfo/pacemaker
>