[Pacemaker] About "record-pending"

[Yan Gao]

On Mon, 2008-10-27 at 10:08 +0100, Andrew Beekhof wrote:
> >> Can you try this one instead?
> >>
> >> diff -r 23c237ed0cbe crmd/te_actions.c
> >> --- a/crmd/te_actions.c	Sun Oct 26 11:20:37 2008 +0100
> >> +++ b/crmd/te_actions.c	Sun Oct 26 11:47:06 2008 +0100
> >> @@ -458,7 +458,7 @@ send_rsc_command(crm_action_t *action)
> >> 		te_start_action_timer(action);
> >> 	}
> >>
> >> -	value = g_hash_table_lookup(action->params,
> >> crm_meta_name(XML_OP_ATTR_PENDING));
> >> +	value = g_hash_table_lookup(action->params,  
> >> crm_meta_name("record_pending"));
> >> 	if(crm_is_true(value)) {
> >> 	    /* write a "pending" entry to the CIB, inhibit notification */
> >> 	    crm_info("Recording pending op %s in the CIB", task_uuid);
> >
> > It works :-), while I'm still using "record-pending" as attribute  
> > name.
> 
> Right.  That was the problem.  We weren't setting and getting meta  
> attributes consistently.
> This is now fixed in
>     http://hg.clusterlabs.org/pacemaker/stable-1.0/rev/1eca6b7f73b3
> 
Great, Thanks!
> >
> > Another issue is it doesn't trigger cib notify, hence mgmtd cannot be
> > aware of the event.
> 
> Is the crm sending the update with the cib_inhibit_notify flag?
> 
If it's LRM_OP_PENDING, it will always be set in:
te_actions.c:290
		call_options |= cib_inhibit_notify; /* We don't want to
 know about these updates */

And should it be like the following at line 289 ?
-if(LRM_OP_PENDING) {
+if(status == LRM_OP_PENDING) {

	
> _______________________________________________
> Pacemaker mailing list
> Pacemaker at clusterlabs.org
> http://list.clusterlabs.org/mailman/listinfo/pacemaker
-- 
Yan Gao
China R&D Software Engineer
ygao at novell.com

Novell, Inc.
SUSE® Linux Enterprise 10
Your Linux is ready
http://www.novell.com/linux