[Pacemaker] [patch] Remove some bashisms from STONITHBasicSanityCheck

Simon Horman horms at verge.net.au
Wed Aug 6 03:29:38 UTC 2008


Hi,

it seems that using let is a bashism, so I just converted things
to use a more verbose syntax which dash seems to accept.

This relates to debian bug #489607
http://bugs.debian.org/489607

Signed-off-by: Simon Horman <horms at verge.net.au>

--- d/fencing/test/STONITHDBasicSanityCheck.in	2008-08-06 13:20:43.000000000 +1000
+++ d/fencing/test/STONITHDBasicSanityCheck.in	2008-08-06 13:13:26.000000000 +1000
@@ -38,23 +38,23 @@
 
 	# Add stonith resource.
 	$LRMADMIN -A s1 stonith null NULL hostlist=$MYSELF
-	[ $? -eq 0 ] || let ERR_COUNT++ 
+	[ $? -eq 0 ] || ERR_COUNT=$(($ERR_COUNT + 1))
 
 	# Start stonith resource, equal to initializing the stonith device.
 	$LRMADMIN -E s1 start 0 0 0
-	[ $? -eq 0 ] || let ERR_COUNT++ 
+	[ $? -eq 0 ] || ERR_COUNT=$(($ERR_COUNT + 1))
 
 	# Test stonith operation: query
 	$APITEST $QUERY $MYSELF $TIMEOUT 0
-	[ $? -eq 0 ] || let ERR_COUNT++ 
+	[ $? -eq 0 ] || ERR_COUNT=$(($ERR_COUNT + 1))
 
 	# Test stonith operation: reset
 	$APITEST $RESET $MYSELF $TIMEOUT 0
-	[ $? -eq 0 ] || let ERR_COUNT++ 
+	[ $? -eq 0 ] || ERR_COUNT=$(($ERR_COUNT + 1))
 
 	# Test stonithd's error handling - to stonith an unaccessible host
 	$APITEST $POWEROFF notexist $TIMEOUT 2
-	[ $? -eq 0 ] || let ERR_COUNT++ 
+	[ $? -eq 0 ] || ERR_COUNT=$(($ERR_COUNT + 1))
 }
 
 




More information about the Pacemaker mailing list