[Pacemaker] [patch] Remove somewhat bogus use of mktemp

Simon Horman horms at verge.net.au
Wed Aug 6 06:16:56 EDT 2008


If its safe not to use mktemp when its not there,
then its safe not to use mtemp when it is there.

Either that or its not safe and a safe replacement is neede.

Signed-off-by: Simon Horman <horms at verge.net.au>

--- 
Andrew, this is one of only two only mktemp related code points that I could
find in pacemaker. The other is in python and I assume it is fine.

diff -r 402d90b4de3c configure.in
--- a/configure.in	Wed Jul 09 14:19:09 2008 +0200
+++ b/configure.in	Wed Aug 06 20:13:26 2008 +1000
@@ -467,20 +467,14 @@
 dnl ************************************************************************
 dnl Check whether non-root user can chown.
 dnl ************************************************************************
-AC_PATH_PROGS(MKTEMP, mktemp)
 
 if test -n "$WHOAMI"; then
   IAM=`$WHOAMI`
 fi
 AC_MSG_CHECKING(if chown works for non-root)
 
-dnl Prefer "mktemp" command.  But some OSes lack it; they can "touch".
-if test -n "$MKTEMP"; then
-  F=`$MKTEMP "./.chown-testXXXXX"`
-else
-  F="./.chown-test.$$"
-  touch $F
-fi
+F="./.chown-test.$$"
+touch $F
 
 if
   case "$IAM" in




More information about the Pacemaker mailing list