[ClusterLabs Developers] [PATCH] libqb: Add support for GNU/Hurd

Jan Pokorný jpokorny at redhat.com
Wed Mar 2 08:25:01 EST 2016


On 02/03/16 11:21 +0100, Svante Signell wrote:
> Attached is an updated patch, the previous one was wrong, since GNU/Hurd does
> not support abstract sockets.

Fix the whitespace error mentioned in-line below first, please.

> With this patch 7 of 8 tests PASS: The failing test ipc.test needs some more
> time to debug.
> 
> I have one question about the testsuite:
> Is it possible to remove the check package overrides in the tests, especially
> for ipc.test? Since check use fork(2) to create a separate address space it is
> very difficult to trace execution with gdb. Any ideas would be appreciated.

(gdb) help set follow-fork-mode
> Set debugger response to a program call of fork or vfork.
> A fork or vfork creates a new process.  follow-fork-mode can be:
>   parent  - the original process is debugged after a fork
>   child   - the new process is debugged after a fork
> The unfollowed process will continue to run.
> By default, the debugger will follow the parent process.

Would the above help you?  You can should be able to break on fork and set
that per your needs repeatedly, if needed.

Note that those implicit forks are needed so that the timeouts can be
enforced, IIUIC.

> From 1190966924f671cfd0cc54ff3805a74b845c74f1 Mon Sep 17 00:00:00 2001
> From: Svante Signell <svante.signell at gmail.com>
> Date: Wed, 2 Mar 2016 10:46:02 +0100
> Subject: [PATCH] Add Hurd support
> 
>   * configure.ac: Define QB_GNU
> 
>   * lib/log_thread.c: Replace second argument of
>   qb_log_thread_priority_set(): logt_sched_param.sched_priority by 0
>   when not supported by the OS.
> 
>   * lib/util.c: Fall back to CLOCK_REALTIME in clock_getres() if
>     CLOCK_MONOTONIC fails.
> 
> ---
>  configure.ac     | 5 +++++
>  lib/log_thread.c | 4 ++++
>  lib/util.c       | 8 ++++++--
>  3 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 7cfde10..10dd0df 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -335,6 +335,11 @@ case "$host_os" in
>  		CP=rsync
>  		AC_MSG_RESULT([Solaris])
>  	;;
> +	*gnu*)
> +		AC_DEFINE_UNQUOTED([QB_GNU], [1],
> + 				   [Compiling for GNU/Hurd platform])
   ^
$ git am 0001-Add-Hurd-support.patch
Applying: Add Hurd support
/home/jpokorny/git/libqb/.git/rebase-apply/patch:17: space before tab in indent.
 				   [Compiling for GNU/Hurd platform])
warning: 1 line adds whitespace errors.

Please fix that.

-- 
Jan (Poki)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.clusterlabs.org/pipermail/developers/attachments/20160302/c8f22b0c/attachment-0003.sig>


More information about the Developers mailing list